Mod Feedback [By Request] RotaryCraft Suggestions

[Reika]

A survival version of the World edit wand would be nice. Or just add a recipe and make it consume blocks from your inventory. The Remote IO block replacer is the only thing other than the TC wand of equal trade that allows anything like this. I am not a fan of magic mods, so TC is out and adding an entire mod for one tool seems like a waste anyways. Since I play SP, it's not a huge deal and I use the World edit wand anyways, but I would like if it used my inventory.

ChromatiCraft has such an item.

 

[Not_Steve]

ChromatiCraft has such an item.

Hype Hype Hype

 

[Sm31415]

Would it be possible to add a slot to the magnetostatic engines so that they can be powered internally by the Flux capacitors?

 

[ljfa]

IIRC you can put flux capacitors in energy cells, so you can place one next to your magnetostatic.

 

[junkumulu]

Will you port mods ay time soon?

 

[The Skeptical Tech]

Just lovely.

 @Override
public boolean equals(Object obj) {
return false;
}

According to that, one of those objects is not even equal to itself.

Worse, every test of list.contains() or map.get() is going to return null with that crap as the key.

That is... just wrong. It looks like one of those things where you make a method stub and fill in "return true/false" just to keep the IDE happy until you add the actual code later.

public float getOptionFloatValue(GameSettings.Options p_74296_1_)
{
return p_74296_1_ == GameSettings.Options.FOV ? this.fovSetting : (p_74296_1_ == GameSettings.Options.GAMMA ? this.gammaSetting : (p_74296_1_ == GameSettings.Options.SATURATION ? this.saturation : (p_74296_1_ == GameSettings.Options.SENSITIVITY ? this.mouseSensitivity : (p_74296_1_ == GameSettings.Options.CHAT_OPACITY ? this.chatOpacity : (p_74296_1_ == GameSettings.Options.CHAT_HEIGHT_FOCUSED ? this.chatHeightFocused : (p_74296_1_ == GameSettings.Options.CHAT_HEIGHT_UNFOCUSED ? this.chatHeightUnfocused : (p_74296_1_ == GameSettings.Options.CHAT_SCALE ? this.chatScale : (p_74296_1_ == GameSettings.Options.CHAT_WIDTH ? this.chatWidth : (p_74296_1_ == GameSettings.Options.FRAMERATE_LIMIT ? (float)this.limitFramerate : (p_74296_1_ == GameSettings.Options.ANISOTROPIC_FILTERING ? (float)this.anisotropicFiltering : (p_74296_1_ == GameSettings.Options.MIPMAP_LEVELS ? (float)this.mipmapLevels : (p_74296_1_ == GameSettings.Options.RENDER_DISTANCE ? (float)this.renderDistanceChunks : (p_74296_1_ == GameSettings.Options.STREAM_BYTES_PER_PIXEL ? this.field_152400_J : (p_74296_1_ == GameSettings.Options.STREAM_VOLUME_MIC ? this.field_152401_K : (p_74296_1_ == GameSettings.Options.STREAM_VOLUME_SYSTEM ? this.field_152402_L : (p_74296_1_ == GameSettings.Options.STREAM_KBPS ? this.field_152403_M : (p_74296_1_ == GameSettings.Options.STREAM_FPS ? this.field_152404_N : 0.0F)))))))))))))))));
}

I don't even...

That monstrosity is going to be an absolute pain to debug.

I like ternaries too, but that is going way too far. Somebody likes LISP too much I think.

 

[Sm31415]

IIRC you can put flux capacitors in energy cells, so you can place one next to your magnetostatic.

No you can't discharge flux capacitors into an energy cell.

 

[1M Industries]

I found another in GameSettings:

Spoiler

 public float getOptionFloatValue(GameSettings.Options p_74296_1_)
{
return p_74296_1_ == GameSettings.Options.FOV ? this.fovSetting : (p_74296_1_ == GameSettings.Options.GAMMA ? this.gammaSetting : (p_74296_1_ == GameSettings.Options.SATURATION ? this.saturation : (p_74296_1_ == GameSettings.Options.SENSITIVITY ? this.mouseSensitivity : (p_74296_1_ == GameSettings.Options.CHAT_OPACITY ? this.chatOpacity : (p_74296_1_ == GameSettings.Options.CHAT_HEIGHT_FOCUSED ? this.chatHeightFocused : (p_74296_1_ == GameSettings.Options.CHAT_HEIGHT_UNFOCUSED ? this.chatHeightUnfocused : (p_74296_1_ == GameSettings.Options.CHAT_SCALE ? this.chatScale : (p_74296_1_ == GameSettings.Options.CHAT_WIDTH ? this.chatWidth : (p_74296_1_ == GameSettings.Options.FRAMERATE_LIMIT ? (float)this.limitFramerate : (p_74296_1_ == GameSettings.Options.ANISOTROPIC_FILTERING ? (float)this.anisotropicFiltering : (p_74296_1_ == GameSettings.Options.MIPMAP_LEVELS ? (float)this.mipmapLevels : (p_74296_1_ == GameSettings.Options.RENDER_DISTANCE ? (float)this.renderDistanceChunks : (p_74296_1_ == GameSettings.Options.STREAM_BYTES_PER_PIXEL ? this.field_152400_J : (p_74296_1_ == GameSettings.Options.STREAM_VOLUME_MIC ? this.field_152401_K : (p_74296_1_ == GameSettings.Options.STREAM_VOLUME_SYSTEM ? this.field_152402_L : (p_74296_1_ == GameSettings.Options.STREAM_KBPS ? this.field_152403_M : (p_74296_1_ == GameSettings.Options.STREAM_FPS ? this.field_152404_N : 0.0F)))))))))))))))));
}

That is one line.

I have not seen a mess of ternaries this big since the 1.2.5 copy of RenderBlocks.

Come to think of it, I have never seen Mojang use a switch statement, which does the same thing as that, only readably. I wonder if they know it exists...?

MUST.......REFRAIN.......FROM.......SCREAMING!!!!!!!!!
Seriously though, that is.....just wrong. I have never seen something that bad outside of a REALLY bad nightmare. What were the developers thinking? Or were they even thinking at all........

 

[RavynousHunter]

MUST.......REFRAIN.......FROM.......SCREAMING!!!!!!!!!
Seriously though, that is.....just wrong. I have never seen something that bad outside of a REALLY bad nightmare. What were the developers thinking? Or were they even thinking at all........

You hit the nail on the head, 'ere. They aren't thinking, and that's the problem. No thinking person would permit such a monstrosity from being written, much less actually used.

 

[keybounce]

You are assuming that the actual source was like that.

Remember, there is a program whose goal is to obfuscate the output from the compiler, into something that is valid bytecode but won't return the original source.

 

[RavynousHunter]

You are assuming that the actual source was like that.

Remember, there is a program whose goal is to obfuscate the output from the compiler, into something that is valid bytecode but won't return the original source.

The bytecode for the various operators must be the same, otherwise, the obfuscated code would never work. Unless the obfuscator goes thru and analyzes the unobfuscated output and changes various forms of control flow to something similar, but not the same, then those will always be the same. Thus an "if" will produce a different bytecode than a ternary statement.

 

[Reika]

You are assuming that the actual source was like that.

Remember, there is a program whose goal is to obfuscate the output from the compiler, into something that is valid bytecode but won't return the original source.

Again, I compare the source of mods to the results of decompilation all the time, and the relation is nearly 1:1. Java is very easily decompiled.


EDIT:
So it appears they do know about switch, but it does them little good.
I found more, this time in SoundHandler:

            switch (SoundHandler.SwitchType.field_148765_a[soundentry.getSoundEntryType().ordinal()])
            {
                case 1:
                  ---stuff---
                    break;
                case 2:
                  ---stuff---
                    break;
                default:
                    throw new IllegalStateException("IN YOU FACE");

 

[1M Industries]

Again, I compare the source of mods to the results of decompilation all the time, and the relation is nearly 1:1. Java is very easily decompiled.


EDIT:
So it appears they do know about switch, but it does them little good.
I found more, this time in SoundHandler:

            switch (SoundHandler.SwitchType.field_148765_a[soundentry.getSoundEntryType().ordinal()])
            {
                case 1:
                  ---stuff---
                    break;
                case 2:
                  ---stuff---
                    break;
                default:
                    throw new IllegalStateException("IN YOU FACE");

GAH!!!! THE PAIN!!!! NOOOOOOOOOOO!!!!!!!!!!!!!!!!!!!!!

 

[RavynousHunter]

That's not too bad, but I cringe every time I see cases without braces. It just looks...wrong. I'm a bit anal with explicitly defining my scope.

 

[Reika]

A new one. This is not the syntax, but the semantics.
Through careful debugging I have determined that Mojang, in its infinite wisdom, has decided to set up the sound system to reload the file from the hard drive every time it plays. Not only is that terrible for performance and hard disk lifespan, but it is going to severely hinder my ability to adapt my sound system.

 

[7thfleet]

How much of an effect on lifespan would that have on an SSD?
*Checks SMART status of drive*

 

[Reika]

How much of an effect on lifespan would that have on an SSD?
*Checks SMART status of drive*

Upsettingly large. I have an SSD too.

 

[ljfa]

Upsettingly large. I have an SSD too.

I doubt that since SSDs are mainly damaged by writing. This reloading should be negligible.
But for an HDD it's worse of course.

 

[DREVL]

I am going to be useless and ask if someone can think of a cool way of telling R how Rotary can cut down trees... Rotary itself doesn't really use wood. But still.

 

[1M Industries]

A new one. This is not the syntax, but the semantics.
Through careful debugging I have determined that Mojang, in its infinite wisdom, has decided to set up the sound system to reload the file from the hard drive every time it plays. Not only is that terrible for performance and hard disk lifespan, but it is going to severely hinder my ability to adapt my sound system.

Right. Time to bug Mojang about fixing that. I really don't want more lag caused by excessive sound usage.