[1.7.10] AgriCraft

[InfinityRaider]

Thank goodness... I read through the tile entity several times thinking I was misunderstanding something!

Anyway, it seemed like you would only need to add a single check in the crop's tile entity to keep weeds from spreading over existing crops.

Codewise is not a problem no, I'm just thinking it over, I guess I'll just throw in a config option.

 

[Cobra1117]

Codewise is not a problem no, I'm just thinking it over, I guess I'll just throw in a config option.

Hey, that's your call if it's appropriate or not.

Unrelated: I'm getting the following error when visiting an existing village in a Mystcraft age:

Spoiler: Stack trace

[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: java.lang.InstantiationException: com.InfinityRaider.AgriCraft.world.StructureGreenhouseIrrigated
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at java.lang.Class.newInstance(Class.java:359)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.structure.MapGenStructureIO.func_143032_b(SourceFile:81)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.structure.StructureStart.func_143020_a(StructureStart.java:104)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.structure.MapGenStructureIO.func_143035_a(SourceFile:69)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.structure.MapGenStructure.func_143027_a(MapGenStructure.java:267)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.structure.MapGenStructure.func_151538_a(MapGenStructure.java:30)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.MapGenBase.func_151539_a(SourceFile:30)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at com.xcompwiz.mystcraft.symbol.symbols.SymbolVillages$TerrainAlteration.alterTerrain(SymbolVillages.java:55)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at com.xcompwiz.mystcraft.world.AgeController.modifyTerrain(AgeController.java:474)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at com.xcompwiz.mystcraft.world.ChunkProviderMyst.func_73154_d(ChunkProviderMyst.java:129)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.ChunkProviderServer.originalLoadChunk(ChunkProviderServer.java:172)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:131)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.World.func_72964_e(World.java:419)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.WorldServer.func_147456_g(WorldServer.java:313)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:183)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:625)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
[02:23:55] [Server thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStreamrintln:748]: at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Tested with Agricraft 1.1.1

Bug does not occur with new villages--only existing ones. Might be due to adding additional mods--Pam's Harvestcraft and Witchery were added around when the stack traces started showing up.

 

[InfinityRaider]

That is weird, I haven't touched the village components for a while. Is it only in Mystcraft dimensions or in the overworld as well?
And if I understand correctly it complains on already generated villages and not while generating new ones?

 

[nimO]

Could it be that there is a part missing from the stack trace? Specifically the part which causes the InstantiationException. (NPE in the GreenHouse for example).

 

[ChatFawkes]

I was wondering what exactly does the strength trait do for crops? I know gain increases in the amount of drops and I'm assuming growth makes it grow faster, but I can't seem to figure out what strength is for? Is it strength against weeds or something like that?

 

[Cobra1117]

That is weird, I haven't touched the village components for a while. Is it only in Mystcraft dimensions or in the overworld as well?
And if I understand correctly it complains on already generated villages and not while generating new ones?

Unfortunately, I didn't have any existing greenhouses in the overworld. It might be a Mystcraft bug or an Agricraft bug. As nim0 pointed out, it seems like some of the stack trace is missing--in the logs there's actually no stack trace (I got the one that I posted from the console). Fortunately, it's not causing a crash, just some slowness. If it continues, I may wipe out the villages file in that dimension and that should fix it.

 

[nimO]

I was wondering what exactly does the strength trait do for crops? I know gain increases in the amount of drops and I'm assuming growth makes it grow faster, but I can't seem to figure out what strength is for? Is it strength against weeds or something like that?

Yes, the strength attribute makes the crop more resistent against weeds. A strength of 10 means 0% chance that weeds can spread to that plant.

 

[Cobra1117]

Two (very minor) rendering bugs:
- Wooden water tanks and wooden irrigation channels made from Extra Utilities' colored oak wood render correctly in the world, but they have the "missing texture" texture in your inventory
- Sprinklers appear semi-transparent if there is an extra utilities tank containing a liquid in the foreground on the screen

 

[InfinityRaider]

Two (very minor) rendering bugs:
- Wooden water tanks and wooden irrigation channels made from Extra Utilities' colored oak wood render correctly in the world, but they have the "missing texture" texture in your inventory
- Sprinklers appear semi-transparent if there is an extra utilities tank containing a liquid in the foreground on the screen

I'm aware of the ExU texture bug, problem is ExU is closed source and I don't know how he does his textures.
The second thing is quite strange, I'll look at it.

 

[Cobra1117]

I'm aware of the ExU texture bug, problem is ExU is closed source and I don't know how he does his textures.
The second thing is quite strange, I'll look at it.

Yeah, I thought it was a tad suspicious that BOTH bugs were Ex. Utils. related... sounds like RWTema isn't doing things the "normal" way.

 

[InfinityRaider]

Yeah, I thought it was a tad suspicious that BOTH bugs were Ex. Utils. related... sounds like RWTema isn't doing things the "normal" way.

Both bugs are also AgriCraft related

 

[nimO]

Two (very minor) rendering bugs:
- Wooden water tanks and wooden irrigation channels made from Extra Utilities' colored oak wood render correctly in the world, but they have the "missing texture" texture in your inventory
- Sprinklers appear semi-transparent if there is an extra utilities tank containing a liquid in the foreground on the screen

Thanks for reporting bugs btw, also feel free to report bugs in the GitHub repository. At the moment its pretty unlikely that I / we forget or overlook bug reports but that might change and its good to keep them in one place

 

[Cobra1117]

Both bugs are also AgriCraft related

lol. Good point!

Thanks for reporting bugs btw, also feel free to report bugs in the GitHub repository. At the moment its pretty unlikely that I / we forget or overlook bug reports but that might change and its good to keep them in one place

Will-do. Do you prefer to discuss feature requests here or on Github? (Also, you might want to put all this in the original post so folks like me report in the correct location! )

 

[InfinityRaider]

Feature requests can go here.

 

[Cobra1117]

Feature requests can go here.

Cool. Added a issue on Github for the sprinkler transparency issue.

 

[InfinityRaider]

For those who wish to use snapshot builds, these are sometimes posted on the GitHub: https://github.com/InfinityRaider/AgriCraft/releases
Using these can be useful for us to gather feedback/bug reports before an official release.

 

[Kel_Co]

I was going to use this mod in a pack, but for some reason the mutations are not working or showing up in the book for me. So yeah, if this gets more stable, I will definitely put it in.

 

[nimO]

I was going to use this mod in a pack, but for some reason the mutations are not working or showing up in the book for me. So yeah, if this gets more stable, I will definitely put it in.

Which mutations specifically? The mutations also wont show up until you have discovered them.

 

[Kel_Co]

Well, I get seeds from cross-breeding wheat, and it show they are a different breed when scanned, but it is not added to the journal

 

[nimO]

Well, I get seeds from cross-breeding wheat, and it show they are a different breed when scanned, but it is not added to the journal

Did you add the Journal to the Seed Analyzer? There is a slot in the GUI where you have to put your Journal.