Depends what "style" of combat you're going for, I guess. If it's a more "vanilla" style, I would say no to any guns, tanks, war machines, etc.
So, I'll say that my opinions on combat here are purely based on a more "vanilla / medieval" style of combats, although with a little bit of Minceraft's...