TickThreading - concurrent entity/tile entity ticks and other optimisations

[nallar]

Done:
http://files.enjin.com/228976/Temp/TTTesting/tps01.png
http://files.enjin.com/228976/Temp/TTTesting/tps02.png
http://files.enjin.com/228976/Temp/TTTesting/tps03.png

Ping to the server:
http://files.enjin.com/228976/Temp/TTTesting/ping.png

Looks like another plugin took over instead, change TT's tps command name in its config to "ttps" and use /ttps.

Not so relevant now, issue isn't related to that. As a workaround, disabling concurrentMovementUpdates in TT's config should fix the issues you're experiencing. Should be able to reenable rateLimitChunkUpdates.

 

[saki2fifty]

/profile a 60:
http://files.enjin.com/228976/Temp/TTTesting/tps04.png[DOUBLEPOST=1373725671][/DOUBLEPOST]

Ah, that might be what's causing problems. Player movement updates aren't being processed correctly after teleporting = server doesn't know where you are = doesn't simulate mobs even when you stand near to them.

But even after deleting the world and spawning at the natural spawn, it was having that same problem before tp'ing. (I think)

 

[saki2fifty]

Looks like another plugin took over instead, change TT's tps command name in its config to "ttps" and use /ttps.

Not so relevant now, issue isn't related to that. As a workaround, disabling concurrentMovementUpdates in TT's config should fix the issues you're experiencing. Should be able to reenable rateLimitChunkUpdates.

disabled and enabled as per the above.

/ttps:
http://files.enjin.com/228976/Temp/TTTesting/ttps.png

I did restart the server, waited about a minute for it "stabilized", and ran the /ttps. Still lags. Going to disable all plugins... easy thing to do.

 

[saki2fifty]

Does TT ever modify the mods in /mods or /coremods? Does it only use whats in /patchedMods?

 

[nallar]

Does TT ever modify the mods in /mods or /coremods? Does it only use whats in /patchedMods?

Modifies coremods folder, unpatched copies in TTBackups folder.

 

[saki2fifty]

• Deleted mods, coremods, plugins, and all TT related stuff from server.
• Copied fresh mods and coremods to server, along with Build#131 of TT
• All plugins disabled (entire folder renamed)
• Deleted ForgeMod.jar and copied down the latest MCPC+ (1.5.2) and named it ForgeMod.jar
• Started the server once.
• Ran PATCHME.sh
• Started the server and it booted with no real problems (I think)

I waited just a minute, no errors in the console, then joined. When I joined, I waited, stayed in survival and after 15 seconds or so, it said "Sakki Sakkyr moved wrongly". Then a few seconds after that the console spammed that I "moved too quickly". Not as many in the console as earlier, but still was saying that. I have all plugins disabled, did not warp, did not fly, or move, or go into creative.

server log: http://pastebin.com/DY1YNeiR
FML log : http://files.enjin.com/228976/Temp/TTTesting/ForgeModLoader-server-0.log
TT log :

Spoiler

2013-07-13 10:38:10 [INFO] [TickThreading] Started TT metrics reporting. This can be disabled in PluginMetrics.cfg

2013-07-13 10:38:44 [INFO] [TickThreading] Skipping version tick handler c magicbees.main.utils.TickHandlerVersion magicbees.main.utils.TickHandlerVersion@7318ad21

2013-07-13 10:38:57 [SEVERE] [TickThreading] TickThreading v1.5.2.131 for MC1.5.2 on 1.5.2 tickthreading,mcpc,spigot,craftbukkit,forge,fml - 1.7.0_25-b15 is installed on this server!

If anything breaks, check if it is still broken without TickThreading

We don't want to annoy mod devs with issue reports caused by TickThreading.

Seriously, please don't.

If it's only broken with TickThreading, report it at https://github.com/nallar/TickThreading/issues/new

Also, you really should be making regular backups. (You should be doing that even when not using TT.)

2013-07-13 10:42:22 [INFO] [TickThreading] Server shutting down - requested at

nallar.insecurity.ThisIsNotAnError: This is not an error.

at nallar.insecurity.InsecurityManager.checkExit(InsecurityManager.java:31)

at net.minecraft.server.MinecraftServer.func_71263_m(MinecraftServer.java:110)

at org.bukkit.craftbukkit.v1_5_R3.CraftServer.shutdown(CraftServer.java:1096)

at org.bukkit.Bukkit.shutdown(Bukkit.java:394)

at org.bukkit.command.defaults.StopCommand.execute(StopCommand.java:28)

at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:189)

at org.bukkit.craftbukkit.v1_5_R3.CraftServer.dispatchCommand(CraftServer.java:564)

at org.bukkit.craftbukkit.v1_5_R3.CraftServer.dispatchServerCommand(CraftServer.java:547)

at net.minecraft.server.dedicated.DedicatedServer.func_71333_ah(DedicatedServer.java:364)

at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:321)

at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:303)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:195)

at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573)

2013-07-13 10:42:28 [INFO] [TickThreading] Saving all player data.

2013-07-13 10:42:28 [INFO] [TickThreading] Done saving player data, now saving 2 worlds.

2013-07-13 10:42:28 [INFO] [TickThreading] World save completed, flushing world data to disk.

2013-07-13 10:42:28 [INFO] [TickThreading] Flushed world data to disk.

2013-07-13 10:42:28 [INFO] [TickThreading] Stopping the server. serverRunning: false, serverIsRunning: true, is crash: false

 

[Jared39]

• Deleted mods, coremods, plugins, and all TT related stuff from server.
• Copied fresh mods and coremods to server, along with Build#131 of TT
• All plugins disabled (entire folder renamed)
• Deleted ForgeMod.jar and copied down the latest MCPC+ (1.5.2) and named it ForgeMod.jar
• Started the server once.
• Ran PATCHME.sh
• Started the server and it booted with no real problems (I think)

I waited just a minute, no errors in the console, then joined. When I joined, I waited, stayed in survival and after 15 seconds or so, it said "Sakki Sakkyr moved wrongly". Then a few seconds after that the console spammed that I "moved too quickly". Not as many in the console as earlier, but still was saying that. I have all plugins disabled, did not warp, did not fly, or move, or go into creative.

server log: http://pastebin.com/DY1YNeiR
FML log : http://files.enjin.com/228976/Temp/TTTesting/ForgeModLoader-server-0.log
TT log :

Spoiler

2013-07-13 10:38:10 [INFO] [TickThreading] Started TT metrics reporting. This can be disabled in PluginMetrics.cfg

2013-07-13 10:38:44 [INFO] [TickThreading] Skipping version tick handler c magicbees.main.utils.TickHandlerVersion magicbees.main.utils.TickHandlerVersion@7318ad21

2013-07-13 10:38:57 [SEVERE] [TickThreading] TickThreading v1.5.2.131 for MC1.5.2 on 1.5.2 tickthreading,mcpc,spigot,craftbukkit,forge,fml - 1.7.0_25-b15 is installed on this server!

If anything breaks, check if it is still broken without TickThreading

We don't want to annoy mod devs with issue reports caused by TickThreading.

Seriously, please don't.

If it's only broken with TickThreading, report it at https://github.com/nallar/TickThreading/issues/new

Also, you really should be making regular backups. (You should be doing that even when not using TT.)

2013-07-13 10:42:22 [INFO] [TickThreading] Server shutting down - requested at

nallar.insecurity.ThisIsNotAnError: This is not an error.

at nallar.insecurity.InsecurityManager.checkExit(InsecurityManager.java:31)

at net.minecraft.server.MinecraftServer.func_71263_m(MinecraftServer.java:110)

at org.bukkit.craftbukkit.v1_5_R3.CraftServer.shutdown(CraftServer.java:1096)

at org.bukkit.Bukkit.shutdown(Bukkit.java:394)

at org.bukkit.command.defaults.StopCommand.execute(StopCommand.java:28)

at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:189)

at org.bukkit.craftbukkit.v1_5_R3.CraftServer.dispatchCommand(CraftServer.java:564)

at org.bukkit.craftbukkit.v1_5_R3.CraftServer.dispatchServerCommand(CraftServer.java:547)

at net.minecraft.server.dedicated.DedicatedServer.func_71333_ah(DedicatedServer.java:364)

at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:321)

at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:303)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:195)

at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573)

2013-07-13 10:42:28 [INFO] [TickThreading] Saving all player data.

2013-07-13 10:42:28 [INFO] [TickThreading] Done saving player data, now saving 2 worlds.

2013-07-13 10:42:28 [INFO] [TickThreading] World save completed, flushing world data to disk.

2013-07-13 10:42:28 [INFO] [TickThreading] Flushed world data to disk.

2013-07-13 10:42:28 [INFO] [TickThreading] Stopping the server. serverRunning: false, serverIsRunning: true, is crash: false

To turn off the moving too quickly error just put anticheatnotify option in the config to false. I had that problem and turning that off fixed it.

 

[saki2fifty]

^ ok, thanks.

Well, I just redid everything again, but this time disable TT completely. Same problem. So... please disregard all that stuff above. Its either Java (going from 8 back to 7) or the latest of UE. Those were the only things changed.

Sorry guys.

 

[nallar]

^ ok, thanks.

Well, I just redid everything again, but this time disable TT completely. Same problem. So... please disregard all that stuff above. Its either Java (going from 8 back to 7) or the latest of UE. Those were the only things changed.

Sorry guys.

It's fine, you were right to assume that it's TT's fault - it usually is!

edit: Oh, and if moving to java 7 did it, then it's my fault anyway for telling you to do that. No idea why that would cause this though.

 

[vince959]

Any bukkit permissions plugin. It will also work with alpha's Forge PEX.[DOUBLEPOST=1373683512][/DOUBLEPOST]

Can you right click one of the broken liquiducts with a clock and post the output? (Or run /dump x y z in console)[DOUBLEPOST=1373683546][/DOUBLEPOST]

Deadlock fixed in latest, other issue looks like it's caused by something with an invalid block ID near that steve's cart. Maybe check with MCEdit?

Got these in console after right clicking it with a clock, is this what you need?

2013-07-15 00:50:28 [INFO] [Minecraft-Client] [CHAT] 2006:conduit.energy:1
2013-07-15 00:50:28 [INFO] [Minecraft-Client] [CHAT] World time: 30088495
2013-07-15 00:50:28 [INFO] [Minecraft-Client] [CHAT] No tile entity at 152_world/0 x,y,z1832,201,-977

 

[vince959]

Another weird behavior is the quarry sometimes (quite frequent actually) spits items into the air instead of sending them to the chest next to it. Disconnect & reconnect power, break and replace the chest do not solve the problem. Restarting the server will make the marked area of the quarry reset to its default area (like you place the quarry without landmarks).

And I cannot place covers on Gregtech machines, I can pry the existing ones out of the machines tho. Without the mod, it doesn't happen.

 

[saki2fifty]

Curious, are the only things TT'ed the mods that you've patched? Or does it work with any sort of entities and tile entities?

 

[nallar]

Curious, are the only things TT'ed the mods that you've patched? Or does it work with any sort of entities and tile entities?

Works with all TEs/Entities, patches are only to fix things which break when multithreaded.[DOUBLEPOST=1373880368][/DOUBLEPOST]

Got these in console after right clicking it with a clock, is this what you need?

2013-07-15 00:50:28 [INFO] [Minecraft-Client] [CHAT] 2006:conduit.energy:1
2013-07-15 00:50:28 [INFO] [Minecraft-Client] [CHAT] World time: 30088495
2013-07-15 00:50:28 [INFO] [Minecraft-Client] [CHAT] No tile entity at 152_world/0 x,y,z1832,201,-977

Should be fixed in latest, any which are currently broken will still need to be fixed after updating.

 

[J0n4t4n]

Hey nallar,
I've tested TickThreading yesterday for the first time and I already like it.
But at the Moment my console is getting spammed with "[INFO] [STDOUT] something on tick went wrong".
I'm receiving that message every 10-40 seconds and it didn't happen before I used TickThreading.
Is that normal? I'm currently using TickThreading-1.5.2.143.
Thanks for your help.

 

[vince959]

Works with all TEs/Entities, patches are only to fix things which break when multithreaded.[DOUBLEPOST=1373880368][/DOUBLEPOST]

Should be fixed in latest, any which are currently broken will still need to be fixed after updating.

Updated to the latest 139 build, and I cannot place covers on Gregtech machines, I can pry the existing ones out of the machines tho. Without the mod, it doesn't happen.

 

[saki2fifty]

edit: Oh, and if moving to java 7 did it, then it's my fault anyway for telling you to do that. No idea why that would cause this though.

No, I don't think that's what it was. I couldn't figure it out, so I just backed it all up, and rebuilt from scratch. Working perfect now!

And on the builds where you have:

Changes

1. Fix #900 (commit: f92c91997ef438927e914e0ed6f48f503a05f6b7) (detail)

Are these fixes from 1.4.7 that you're carrying over to 1.5.2? If so, you have a long way to go...

 

[saki2fifty]

Does your autoupdate script still work for 1.5.2? The script says 1.4.7.
https://github.com/nallar/TickThreading/wiki
https://github.com/nallar/TickThreading/wiki/SSH-Update-Script

Also, i'd like to install the VisualVM so if I change my startup to what it shows here : https://github.com/nallar/TickThreading/wiki/start any problems with leaving it there, or is this more for profiling / testing?

 

[vince959]

Got this after updated to latest 143 build right after the server finish startup loading.

2013-07-16 12:09:41 [SEVERE] [TickThreading] Exception ticking TileEntity c appeng.me.tile.TileStorageBus @317486569
in 152_world/0 at x, y, z: -2840, 65, 65 java.util.ConcurrentModificationException
at java.util.LinkedList$ListItr.checkForComodification(Unknown Source)
at java.util.LinkedList$ListItr.next(Unknown Source)
at appeng.util.Platform.sumItemToList(Platform.java:935)
at appeng.me.tile.TileController.notifyAddItems(TileController.java:1771)
at appeng.me.tile.TileStorageBus.updateTileEntity(TileStorageBus.java:134)
at appeng.common.base.AppEngTile.func_70316_g(AppEngTile.java:487)
at nallar.tickthreading.minecraft.tickregion.TileEntityTickRegion.doTick(TileEntityTickRegion.java:90)
at nallar.tickthreading.minecraft.tickregion.TickRegion.run(TickRegion.java:35)
at nallar.tickthreading.minecraft.ThreadManager$2.run(ThreadManager.java:101)
at nallar.tickthreading.minecraft.ThreadManager$1.run(ThreadManager.java:43)
at nallar.tickthreading.util.FakeServerThread.run(FakeServerThread.java:16)

 

[nallar]

Does your autoupdate script still work for 1.5.2? The script says 1.4.7.
https://github.com/nallar/TickThreading/wiki
https://github.com/nallar/TickThreading/wiki/SSH-Update-Script

Also, i'd like to install the VisualVM so if I change my startup to what it shows here : https://github.com/nallar/TickThreading/wiki/start any problems with leaving it there, or is this more for profiling / testing?

The problem with leaving it as that is that if anyone knows the port (or uses a port scanning program to find it) they can use jvisualvm or other programs to restart your server, make it take a heap dump (which freezes for a while, uses lots of disk space). If you set it up with password authentication that's not a problem, but the tutorial doesn't cover that. (and I've never got that working )[DOUBLEPOST=1374012736][/DOUBLEPOST]

No, I don't think that's what it was. I couldn't figure it out, so I just backed it all up, and rebuilt from scratch. Working perfect now!

And on the builds where you have:


Are these fixes from 1.4.7 that you're carrying over to 1.5.2? If so, you have a long way to go...

Most fixes in 1.4.7 are already in the 1.5 builds, other than the AE changes. The problem is that mods change, so new fixes are needed.[DOUBLEPOST=1374012780][/DOUBLEPOST]

Got this after updated to latest 143 build right after the server finish startup loading.

2013-07-16 12:09:41 [SEVERE] [TickThreading] Exception ticking TileEntity c appeng.me.tile.TileStorageBus @317486569
in 152_world/0 at x, y, z: -2840, 65, 65 java.util.ConcurrentModificationException
at java.util.LinkedList$ListItr.checkForComodification(Unknown Source)
at java.util.LinkedList$ListItr.next(Unknown Source)
at appeng.util.Platform.sumItemToList(Platform.java:935)
at appeng.me.tile.TileController.notifyAddItems(TileController.java:1771)
at appeng.me.tile.TileStorageBus.updateTileEntity(TileStorageBus.java:134)
at appeng.common.base.AppEngTile.func_70316_g(AppEngTile.java:487)
at nallar.tickthreading.minecraft.tickregion.TileEntityTickRegion.doTick(TileEntityTickRegion.java:90)
at nallar.tickthreading.minecraft.tickregion.TickRegion.run(TickRegion.java:35)
at nallar.tickthreading.minecraft.ThreadManager$2.run(ThreadManager.java:101)
at nallar.tickthreading.minecraft.ThreadManager$1.run(ThreadManager.java:43)
at nallar.tickthreading.util.FakeServerThread.run(FakeServerThread.java:16)

Will be fixed after I update the AE changes for 1.5.

 

[saki2fifty]

One last thing for the day. If I update my server with a mod, and rerun the .sh patch, will it mess anything up with patching and already patched mod? I did that, and on a few of them it said True on overwriting, like it made a change and wrote something to the mod.

Thx.