ReactorCraft! Radiation is bad?

[Reika]

An easy, but impractical way to fix this, would be to call a function, to check if the container it is being pumped into is on a list (which would list all voiding blocks that you know about), and if return equals true, then it won't pump into it. The dropping it onto the ground and waiting for it to despawn, as well as voiding it. An easy fix for the first one is that players can't throw it, and do something similar to the list idea for it, so people can't just use turtles to drop it. As for the voiding thing, maybe it can't pump into a tesseract, ender tank etc. Also, maybe make it so it cant spill onto the ground unless there are x blocks nearby (the machines for your reactor thing). At the end of the day, you can only do so much. If players really want to, they are going to find a way to bypass it.

I cannot control this.

 

[ThatOneSlowking]

Reflection
(really it's introspection because I am not changing anything, and it actually requires a core mod as well)

As an example, here is how to get (as an Item) a Buildcraft gold power pipe.

Class.forName("buildcraft.BuildCraftTransport").getField("pipePowerGold").get(null)

Coremods (asm code)

The code above is compiled down to bytecode. Here is the result (well, turned into a readable format - it's usually unreadable)

  L0
    LINENUMBER 54 L0
    NEW net/minecraft/item/ItemStack
    DUP
    LDC "buildcraft.BuildCraftTransport"
    INVOKESTATIC java/lang/Class.forName (Ljava/lang/String;)Ljava/lang/Class;
    LDC "pipePowerGold"
    INVOKEVIRTUAL java/lang/Class.getField (Ljava/lang/String;)Ljava/lang/reflect/Field;
    ACONST_NULL
    INVOKEVIRTUAL java/lang/reflect/Field.get (Ljava/lang/Object;)Ljava/lang/Object;
    CHECKCAST net/minecraft/item/Item
    ICONST_1
    ICONST_0
    INVOKESPECIAL net/minecraft/item/ItemStack.<init> (Lnet/minecraft/item/Item;II)V
    ASTORE 1

An example of modifying this code is here. This code turns

Block.blocksList[l].harvestBlock(this.theWorld, this.thisPlayerMP, par1, par2, par3, i1);

into

boolean x = Block.blocksList[l].harvestBlock(this.theWorld, this.thisPlayerMP, par1, par2, par3, i1);
Veinminer.instance.blockMined(this.theWorld, this.thisPlayerMP, par1, par2, par3, x, i1);

Yes, it is difficult.

As for Greg doing ASM, he doesn't do any (as far as the version in TPPI, anyway). He does all his changes by being last (if you can be last to edit recipes, for example, you can just change the recipes without having to worry about other mods changing them.

In all seriousness the parts I did understand are pretty intresting, specifically what would happen if two mods attempted to be last at the same time?

 

[Colensocon1]

You could just place the waste in say a chest and force wrench it or a hardened chest or something similar and then void that

 

[Reika]

You could just place the waste in say a chest and force wrench it or a hardened chest or something similar and then void that

Damn...this is completely true.

 

[Colensocon1]

Damn...this is completely true.

I don't think there is a way to stop this one :/[DOUBLEPOST=1396049932][/DOUBLEPOST]Also I'm curious what would happen if a plugin like clearlagg tryed to remove the waste like a lot f servers have this plugin and most set it to clear all ground items every 5 minutes or so wouldn't this destroy the item or does your code prevent things like this?

 

[Reika]

I don't think there is a way to stop this one :/[DOUBLEPOST=1396049932][/DOUBLEPOST]Also I'm curious what would happen if a plugin like clearlagg tryed to remove the waste like a lot f servers have this plugin and most set it to clear all ground items every 5 minutes or so wouldn't this destroy the item or does your code prevent things like this?

It depends on how the plugin works.

 

[ThatOneSlowking]

It depends on how the plugin works.

Any non-mob or non-player entitites. It doesnt do mobs, but it gets rid of carts, dropped items, paintings, etc.

 

[Reika]

Any non-mob or non-player entitites. It doesnt do mobs, but it gets rid of carts, dropped items, paintings, etc.

I mean on how they remove them.

 

[ThatOneSlowking]

I mean on how they remove them.

I want to say it just deletes them from world, but im unsure of how... I want to say using despawn code on items at the same time, but...

 

[Reika]

I want to say it just deletes them from world, but im unsure of how... I want to say using despawn code on items at the same time, but...

But how does it delete them?
Does it call setDead()? Or does it work like /kill and deal millions of hearts of void damage? The items are immune to the latter.

 

[portablejim]

In all seriousness the parts I did understand are pretty intresting, specifically what would happen if two mods attempted to be last at the same time?

Probably a crash. (FML would just throw it's hands up in the air and complain about unrealistic demands.)

 

[Reika]

Probably a crash. (FML would just throw it's hands up in the air and complain about unrealistic demands.)

In my experience, it is the one which comes after alphabetically.

 

[Qazplm601]

this is a very interesting topic to read.

 

[trajing]

Can't FML use corotines or do you not have those in java?

 

[immibis]

An easy, but impractical way to fix this, would be to call a function, to check if the container it is being pumped into is on a list (which would list all voiding blocks that you know about), and if return equals true, then it won't pump into it.

What stops you from putting fuel into a hopper attached to an incinerator/trashcan/void pipe/nullifier?

Well, the entity never dies, so it falls forever. But you are right in that this functionally eliminates it.

Actually, entities do start taking damage once they reach a certain point, just like players.

Can't FML use corotines or do you not have those in java?

Not sure how this is relevant.

 

[Reika]

Can't FML use corotines or do you not have those in java?

What is a "Corotine"?

What stops you from putting fuel into a hopper attached to an incinerator/trashcan/void pipe/nullifier?

This is exactly the problem I am trying to get around.

Actually, entities do start taking damage once they reach a certain point, just like players.

I made the entity immune to all damage.

 

[immibis]

This is exactly the problem I am trying to get around.

I have no idea how Reactorcraft works, but what if fuel could only be handled by Reactorcraft blocks, and not by the player or machines from other mods?

 

[Reika]

I have no idea how Reactorcraft works, but what if fuel could only be handled by Reactorcraft blocks, and not by the player or machines from other mods?

Fuel is not the issue; waste is. That said, it is probably my only solution. It is not possible with items, so I need to design some sort of other mechanic.

 

[trajing]

What is a "Corotine"?


This is exactly the problem I am trying to get around.


I made the entity immune to all damage.

I may have misspelled it, but it allows you to run two different bits of code at the same time.

 

[Reika]

I may have misspelled it, but it allows you to run two different bits of code at the same time.

That is called multithreading, and has nothing to do with the issue at hand. It is also very dangerous.