MineTweaker/ModTweaker - A help and suggestions thread.

[jordsta95]

Is that the entire scipt? If not, can I see the entire scipt? Because I don't see Stick anywhere in that line.

Stick Recipes.zs would be the name of the file, doesn't always mean it will contain a stick in the recipe

 

[goreae]

Stick Recipes.zs would be the name of the file, doesn't always mean it will contain a stick in the recipe

ah. But still, the rest of the scipt would be nice.

 

[jordsta95]

ah. But still, the rest of the scipt would be nice.

Yeah, I wanted to ask for it but seeing as no values were used, it's not that important... just the imports and the line that is errored

 

[1SDAN]

Here's the entire script:

#Bundled Sticks Recipe
recipes.addShapedMirrored
(
  <customitems:bundled_sticks>, 
  [
    [
      <customitems:crude_rod>, 
      <customitems:rubber_band>
    ], 
    [
      <customitems:rubber_band>, 
      <customitems:crude_rod>
    ]
  ]
);
#Ladder Recipe
recipes.addShapedMirrored
(
  <minecraft:ladder>.withTag
  (
    {
     CanPlaceOn:
     [
       customitems:coarse_dirt
     ]
    }
  ),
  [
    [
     <customitems:bundled_sticks>,
     <customitems:crude_rod>
    ],
    [
     <customitems:crude_rod>,
      <customitems:bundled_sticks>
    ]
  ]
);

The adventure backport mod was made by our very own @ljfa

 

[goreae]

Yeah, I wanted to ask for it but seeing as no values were used, it's not that important... just the imports and the line that is errored

I don't see why an import would even be necessary. NBT just doesn't work like that. You ca n put whatever stuff you want into the NBT data, as long asit's written out properly. And if a mod looks for certain NBT data, like adventure backports looks for canPlaceOn, then it will. Using NBT data like this, you can have vanilla items that behave in special ways with modded mechanics, but still retain their data when the mod is removed and replaced. A brilliant example of this is the vanilla seeds in @InfinityRaider's agricraft.

I'm sorry, I'm rambling a bit. The point is, the NBT data doesn't need an import. If it's structured wrong, it may crash, but that's it.

And try putting angle brackets (<>) around customitems:coarse_dirt.

 

[jordsta95]

And try putting angle brackets (<>) around customitems:coarse_dirt.

That's probably it *facepalms*

 

[goreae]

Besides the issue here, I'd like to say a few words on making minetweaker recipes more readable.

For a normal programming language, giving each encapsulator its own line is jus expected. With them, it makes everything much cleaner and easier to read. This is not the case with Minetweaker, however. Methods are explaining a recipe in a space. That's how you see Let's take the recipe for Thermal Expansion's pulverizer for instance. If I used what you're using, it would come out long, ugly, and harder to understand at a glance:

#Assume there are proper variables defining each of these terms higher up in this scipt.
recipes.addShaped
(
    pulveriser,
    [
        [
            null,
            piston,
            null
        ],
        [
            flint,
            frame,
            flint
        ],
        [
            gear,
            coil,
            gear
        ]
    ]
);

You sort of have to flip around the words in your head a bit. Now let's try putting each item on a line for its row, like this:

#Assume there are proper variables defining each of these terms higher up in this scipt.
recipes.addShaped
(
    pulveriser,
    [
        [
            null, piston, null
        ],
        [
            flint, frame, flint
        ],
        [
            gear, coil, gear
        ]
    ]
);

See? Now it's much easier to understand what's going on in the recipe at a quick glance, while still keeping the traditional spacing rules. I'm perfectly fine with everyone using this method. However, this is my prefered method:

#Assume there are proper variables defining each of these terms higher up in this scipt.
recipes.addShaped(
    pulveriser,    [[null, piston, null],
                    [flint, frame, flint],
                    [gear, coil, gear]]);

Nice and compact. Easy to read. It looks like a crafting recipe. It also looks really clean to me.

I'm not trying to attack anyone or force my opinions on others. Just trying to help out. The easier it is to read code, the easier it is for the maintainer to debug it, and the easier it is for others to help the maintainer debug it.

 

[jordsta95]

Besides the issue here, I'd like to say a few words on making minetweaker recipes more readable.

For a normal programming language, giving each encapsulator its own line is jus expected. With them, it makes everything much cleaner and easier to read. This is not the case with Minetweaker, however. Methods are explaining a recipe in a space. That's how you see Let's take the recipe for Thermal Expansion's pulverizer for instance. If I used what you're using, it would come out long, ugly, and harder to understand at a glance:

#Assume there are proper variables defining each of these terms higher up in this scipt.
recipes.addShaped
(
    pulveriser,
    [
        [
            null,
            piston,
            null
        ],
        [
            flint,
            frame,
            flint
        ],
        [
            gear,
            coil,
            gear
        ]
    ]
);

You sort of have to flip around the words in your head a bit. Now let's try putting each item on a line for its row, like this:

#Assume there are proper variables defining each of these terms higher up in this scipt.
recipes.addShaped
(
    pulveriser,
    [
        [
            null, piston, null
        ],
        [
            flint, frame, flint
        ],
        [
            gear, coil, gear
        ]
    ]
);

See? Now it's much easier to understand what's going on in the recipe at a quick glance, while still keeping the traditional spacing rules. I'm perfectly fine with everyone using this method. However, this is my prefered method:

#Assume there are proper variables defining each of these terms higher up in this scipt.
recipes.addShaped(
    pulveriser,    [[null, piston, null],
                [flint, frame, flint],
                [gear, coil, gear]]);

Nice and compact. Easy to read. It looks like a crafting recipe. It also looks really clean to me.

Personally I do it all on one line as it makes debugging easier for me

recipes.addShaped(pulveriser,    [[null, piston, null],[flint, frame, flint],[gear, coil, gear]]);

So that everything is in one place, so that I can see instantly is there is a missing input e.g.

recipes.addShaped(pulveriser,    [[null, piston, null],[flint, frame, flint],[gear, gear]]);

But then I can also go along the line saying to myself "bracket open, square bracket open, square bracket open, square bracket close, ..."etc.
and then when those two checks are out of the way it's checking is stuff named right, did I forget to encase non-defined values e.g. putting "minecraft:string" not "<minecraft:string>"

 

[goreae]

Personally I do it all on one line as it makes debugging easier for me

recipes.addShaped(pulveriser,    [[null, piston, null],[flint, frame, flint],[gear, coil, gear]]);

So that everything is in one place, so that I can see instantly is there is a missing input e.g.

recipes.addShaped(pulveriser,    [[null, piston, null],[flint, frame, flint],[gear, gear]]);

But then I can also go along the line saying to myself "bracket open, square bracket open, square bracket open, square bracket close, ..."etc.
and then when those two checks are out of the way it's checking is stuff named right, did I forget to encase non-defined values e.g. putting "minecraft:string" not "<minecraft:string>"

That's also perfectly valid. My only concern with that way is it tends to get really cluttered-looking really fast. I mean just look at phoenixReborn's scipts. It's a massive block of text.

 

[jordsta95]

That's also perfectly valid. My only concern with that way is it tends to get really cluttered-looking really fast. I mean just look at phoenixReborn's scipts. It's a massive block of text.

I guess it depends how many values you set, and use... if you have stuff that has a lot of long IDs it's bad, but 20 characters or less is fine (for each item)

But when it comes to stuff like Thaumcraft's Arcane Workbench, I will break the line after the aspects

 

[1SDAN]

And try putting angle brackets (<>) around customitems:coarse_dirt.

#Ladder Recipe
recipes.addShapedMirrored
(
  <minecraft:ladder>.withTag
  (
    {CanPlaceOn:[<customitems:coarse_dirt>]}
  ),
  [
    [<customitems:bundled_sticks>, <customitems:crude_rod>],
    [<customitems:crude_rod>, <customitems:bundled_sticks>]
  ]
);

Um,

ERROR: Stick Recipes.zs:16 > Cannot cast minetweaker.item.IItemStack to minetweaker.data.IData
ERROR: Error executing Stick Recipes.zs: null

 

[goreae]

Alright, I think I got it now. I looked at the adventure backbort Curseforge page, and I used the commands provided and /mt hand to get this. customitems:course_dirt has to be in parentheses. So the recipe looks like this:

recipes.addShapedMirrored
(
  <minecraft:ladder>.withTag
  (
    {CanPlaceOn:["customitems:coarse_dirt"]}
  ),
  [
    [<customitems:bundled_sticks>, <customitems:crude_rod>],
    [<customitems:crude_rod>, <customitems:bundled_sticks>]
  ]
);

 

[jordsta95]

#Ladder Recipe
recipes.addShapedMirrored
(
  <minecraft:ladder>.withTag
  (
    {CanPlaceOn:[<customitems:coarse_dirt>]}
  ),
  [
    [<customitems:bundled_sticks>, <customitems:crude_rod>],
    [<customitems:crude_rod>, <customitems:bundled_sticks>]
  ]
);

Um,

ERROR: Stick Recipes.zs:16 > Cannot cast minetweaker.item.IItemStack to minetweaker.data.IData
ERROR: Error executing Stick Recipes.zs: null

Goreae beat me to it

 

[1SDAN]

Alright, I think I got it now. I looked at the adventure backbort Curseforge page, and I used the commands provided and /mt hand to get this. customitems:course_dirt has to be in parentheses. So the recipe looks like this:

recipes.addShapedMirrored
(
  <minecraft:ladder>.withTag
  (
    {CanPlaceOn:["customitems:coarse_dirt"]}
  ),
  [
    [<customitems:bundled_sticks>, <customitems:crude_rod>],
    [<customitems:crude_rod>, <customitems:bundled_sticks>]
  ]
);

It worked! Thank you for the help.

 

[goreae]

It worked! Thank you for the help.

Any time.

 

[Empmortakaten]

Greetings again. Need a bit of help.

I am trying to set up a casting basin recipe that doesn't require anything to be in the basin in order to pour the block.

The <???> is where I'm getting stuck, because I can't figure out what to put there. Every variation I am trying is requiring me to have a block in the casting basin.

mods.tconstruct.Casting.addBasinRecipe(<Metallurgy:base.block:2>, <liquid:manganese.molten> * 1296, <???>, false, 100);

 

[jordsta95]

Greetings again. Need a bit of help.

I am trying to set up a casting basin recipe that doesn't require anything to be in the basin in order to pour the block.

The <???> is where I'm getting stuck, because I can't figure out what to put there. Every variation I am trying is requiring me to have a block in the casting basin.

mods.tconstruct.Casting.addBasinRecipe(<Metallurgy:base.block:2>, <liquid:manganese.molten> * 1296, <???>, false, 100);

I believe you can either put null, or remove that field. If that doesn't work do <minecraft:air>

 

[goreae]

Greetings again. Need a bit of help.

I am trying to set up a casting basin recipe that doesn't require anything to be in the basin in order to pour the block.

The <???> is where I'm getting stuck, because I can't figure out what to put there. Every variation I am trying is requiring me to have a block in the casting basin.

mods.tconstruct.Casting.addBasinRecipe(<Metallurgy:base.block:2>, <liquid:manganese.molten> * 1296, <???>, false, 100);

What Jordan said. Look at the example recipe in the wiki:

mods.tconstruct.Casting.addBasinRecipe(<minecraft:iron_ingot>, <liquid:iron.molten>, null, false, 20);

 

[Empmortakaten]

I believe you can either put null, or remove that field. If that doesn't work do <minecraft:air>

minecraft:air didn't work, same with just removing it, but null did.

mods.tconstruct.Casting.addBasinRecipe(<Metallurgy:base.block:2>, <liquid:manganese.molten> * 1296, null, false, 100);

Thank you.

 

[Cytheruk]

Minetweaker's Wiki is down