#BlameMojang

[Someone Else 37]

Reika posted a few more bits of Mojang code derpiness a while back. Here's one:

Speaking of dumb code, an example from vMC in the Block class:

public void dropBlockAsItem(World world, int x, int y, int z, int fortune) {
dropBlockAsItemWithChance(world, x, y, z, fortune, 1);
}

public void dropBlockAsItemWithChance(World world, int x, int y, int z, int fortune, float chance) {
dropBlockAsItem_do(world, x, y, z, fortune, chance);
}

private void dropBlockAsItem_do(World world, int x, int y, int z, int fortune, float chance) {
dropBlockAsItem_do_do(world, x, y, z, fortune, chance);
}

private void dropBlockAsItem_do_do(World world, int x, int y, int z, int fortune, float chance) {
<actual drop code>
}

 

[RavynousHunter]

That probably comes from the decompiler.
I think he was referring to how this is hardcoded into the pickaxe class.

That is also horrifying. Though, I thought proper if's and ternaries compiled differently into Java bytecode...hm.

 

[trajing]

It's so mangled I don't want to bother trying to figure out what it means. >.>

 

[Reika]

Reika posted a few more bits of Mojang code derpiness a while back. Here's one:

Do not forget these.

public boolean equals(Object o)
{
return false;
}

switch(p_384788_2)
{
case 0:
<do stuff>
break;
case 1:
<do stuff>
break;
default:
throw new IllegalArgumentException("IN YOU FACE!");
}

try
{
<url loading code>
}
catch (MalFormedURLException ex)
{
throw new Error("TODO: Sanely handle URL Exception :D");
}

 

[Reika]

Oh, and who could forget the time I was asked to make a custom anvil, and found that most of the active anvil code is in the Container/GUI classes, and that it was hardcoded to the vanilla anvil block?

 

[gold49]

Oh, and who could forget the time I was asked to make a custom anvil, and found that most of the active anvil code is in the Container/GUI classes, and that it was hardcoded to the vanilla anvil block?

That's...just...huh?!

 

[trajing]

We need to make a Forge addon that fixes these issues with vMC, so that we have a version of MC that's actually sanely coded.
EDIT: Fixed grammar

 

[Strikingwolf]

We need to make a Forge addon that fixes these issues with vMC, so that we have an actually version of MC that's actually sanely coded.

Hey, don't tell me I haven't thought of it before.

 

[Celestialphoenix]

CoolPhoenix Team!

This is a thing now?

Spoiler

New icon needed.

 

[PODonnell]

My lawn mower won't start.........Thanks MOJANG....

Wait that's not what this thread is about?
*wanders off looking for his old train set*

 

[OnyxDarkKnight]

Oh, and who could forget the time I was asked to make a custom anvil, and found that most of the active anvil code is in the Container/GUI classes, and that it was hardcoded to the vanilla anvil block?

It's one of the many weird things about Minecraft. If I'm correct, the same thing applies to enchanting. All the code logic is in the Container/GUI classes.

 

[Strikingwolf]

It's one of the many weird things about Minecraft. If I'm correct, the same thing applies to enchanting. All the code logic is in the Container/GUI classes.

Gah

That definitely needs to not be a thing...

 

[lenscas]

Striking loves the MC code

Who doesn't like MC code?

 

[trajing]

Who doesn't like MC code?

Mojang.

 

[Strikingwolf]

Striking loves the MC code

Yeah, just like I love Java
I felt physical discomfort saying that

 

[trajing]

Both Java and the JVM have issues, but they're still decent. However, once MS fully releases the cross-platform .NET runtime, I'm switching.

 

[Strikingwolf]

Both Java and the JVM have issues, but they're still decent. However, once MS fully releases the cross-platform .NET runtime, I'm switching.

Same m8, same. C# is much better than Java, even if I'm not particular to their style of coding

 

[OnyxDarkKnight]

Same m8, same. C# is much better than Java, even if I'm not particular to their style of coding

But will Minecraft ever be created in C#? To be honest, I'd prefer a C++ version. I like it more than Java or C#.

 

[Strikingwolf]

But will Minecraft ever be created in C#? To be honest, I'd prefer a C++ version. I like it more than Java or C#.

I'd prefer a Rust version

Although C# would be better than Java

 

[trajing]

C++

Striking's about to murder you.

Anyway, that'd be unnecessarily hard to mod.