Title:
Skyfactory 2.5 MultiPlayer recipe desync
Launcher Version:N/A
Modpack:Skyfactory
Modpack Version:2.5
Log Link:
Details of the issue:On "Team Canada's" (Etho, PauseUnpause, VintageBeef) playthrough of SkyFactory 2.5 an issue was encountered.
Neither Etho nor Pause saw a recipe for turning a block of iron in to iron ingots.
In Single Player this issue is not apparent.
In Multi Player this issue is repeatable (at least I was able to reproduce it).
ShapelessRecipes.zs
recipes.addShapeless(<minecraft:iron_ingot>, [<ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>]);
recipes.addShapeless(<minecraft:iron_ingot> * 9, [<ore:blockIron>]);
ShapedRecipes.zs
recipes.remove(<minecraft:iron_ingot>);
The issue appears to be a race condition between removing the recipe in one file and adding it in another file. I am sure that putting the changes in the correct order in a SINGLE file fixed the issue, but I'm not sure what caused them to be read out of the expected order when in two files.
It is possible that there are other, similar, issues related to removing recipes in one file and adding (some of) them back in another file.
Neither Etho nor Pause saw a recipe for turning a block of iron in to iron ingots.
In Single Player this issue is not apparent.
In Multi Player this issue is repeatable (at least I was able to reproduce it).
ShapelessRecipes.zs
recipes.addShapeless(<minecraft:iron_ingot>, [<ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>, <ore:nuggetIron>]);
recipes.addShapeless(<minecraft:iron_ingot> * 9, [<ore:blockIron>]);
ShapedRecipes.zs
recipes.remove(<minecraft:iron_ingot>);
The issue appears to be a race condition between removing the recipe in one file and adding it in another file. I am sure that putting the changes in the correct order in a SINGLE file fixed the issue, but I'm not sure what caused them to be read out of the expected order when in two files.
It is possible that there are other, similar, issues related to removing recipes in one file and adding (some of) them back in another file.