Mystcraft delayed - Waiting for PR to get accepted

  • Please make sure you are posting in the correct place. Server ads go here and modpack bugs go here
  • The FTB Forum is now read-only, and is here as an archive. To participate in our community discussions, please join our Discord! https://ftb.team/discord

Matterbound

New Member
Jul 29, 2019
58
0
0
I saw this on the 1.4.6 update page here and I'm not really sure what this means for the pack. Will the entire pack be delayed because of this? If so, for how long? Or does this simply mean that Mystcraft will not be included in the next release?

Thanks!
 
Basically some of the variables and function that mystcraft was using isn't usable so he is trying to find a way around it. The packs will likely be released anyway as Slowpoke said in his stream this morning that mystcraft being delayed shouldn't affect it since it doesn't add world gen and can be added later easily. He was testing the mindcrack pack this morning and claimed that he was going to get in touch with Guude and should have it released tonight. No idea for the others at the moment.
 
No, it's not delaying the pack. It just means that Mystcraft might not be in immediately. It will be added when it's ready. PR stands for prerelease, i'd imagine.
 
It likely means "pull request". That means that the code is ready, but it needs to be integrated ("pulled") into the main code branch on github. And the person who needs to accept the pull request might be asleep due to timezone differences or otherwise unavailable.

After integrating the new code it still needs to be tested.
 
From XCompWiz's blog:
In the process of updating the last public release to 1.4.6 I found that not everything transitioned smoothly.
A few functions/variables that Mystcraft used became inaccessible. I have pushed a PR to Forge, but don’t know how one of the newer systems works so I can’t do it quite right. I’m sure Lex or cpw could fix it, but Lex isn’t handling PRs right now and cpw hasn’t been online very frequently of late.
I will attempt to learn this new system so that it can be merged in directly, which will hopefully get it in sooner.
Again, this release will not include Pages or Modifiers or any of the newer content. It is an update of the last release, built on 1.4.6, with some bug fixes and such.
Hopefully the release will be soon, but I can’t say when.
He is pretty much just waiting on cpw to get online at some point.