Bug FTB Infinity Evolved Skyblock 1.3.0 Incompatibility between FTB Trophies and Decocraft 2.4.2

  • Thread starter Thread starter halfslab
  • Start date Start date
  • This section is closed. Please do bug reports over at the FTB GitHub repos.
  • The FTB Forum is now read-only, and is here as an archive. To participate in our community discussions, please join our Discord! https://ftb.team/discord
H

halfslab

Guest
In the latest version of Infinity Evolved Skyblock (1.3.0) the Decocraft mod was updated and the method called render in the com.mia.craftstudio.minecraft.client.CSClientModelWrapperVBO class has a new argumet that it didn't have at version 2.3.3 (the version used in the version 1.2.0 of the pack) and FTB Trophies uses that method when rendering the trophy item. That makes the game crash every time the game tries to render a trophy item in you inventory

The FTB Trophies mod needs to be fixed or removed from the pack or the Decocraft mod downgraded to 2.3.3.

Decocraft 2.3.3 render method signature:
Code:
public void render(Object instanceRenderState, float timeSinceLastRender, boolean renderOutline, float rotationAngle, Vector3 rotationVector, Vector3 preRotataionTranslation, Vector3 postRotataionTranslation)

Decocraft 2.3.4 and newer:
Code:
public void render(Object instanceRenderState, float timeSinceLastRender, int pass, boolean renderOutline, float rotationAngle, Vector3 rotationVector, Vector3 preRotataionTranslation, Vector3 postRotataionTranslation)

(Note the new int pass argument)

I managed to fix it by decompiling the FTB Trophies mod and modifying the com.mia.ftbtrophies.client.renderers.RendererTrophy class by changing the 3 calls to the com.mia.craftstudio.minecraft.client.CSClientModelWrapperVBO.render method by adding the integer '2' as the new argument, and then recompiling the class and replacing the compiled class in the mod .jar file.

I'd love to share my fixed jar, but I can't since the FTB Trophies mod is "All rights reserved".

Please fix this and release an update to the modpack.