mcpc+ xycraft fixed ?

[Slind]

Hey guys,

i wrote this in the changelog of the last mcpc+ version:

Don't call ChunkDataEvent.Load async. Fixes Xycraft ChunkDataEvent.Load handling. Fixes #604, #588.

Does this mean i can reenable xy-craft ?

 

[Belone]

Why don't you just try? If it still has problems then you can always disable it again...

 

[Slind]

cant try it.

would take me hours on a testserver

 

[Asdrubael]

12:31:39 [INFORMATION] Attempted to place a tile entity (soaryn.xycraft.machines.block.multiblock.TileMultiCopy@66124a41) at -45,103,388 (REDPOWERWORLD_STONE) where there was no entity tile!
12:31:39 [INFORMATION] Chunk coordinates: -48,384
12:31:39 [SCHWERWIEGEND] java.lang.Exception
12:31:39 [SCHWERWIEGEND] at zz.a(Chunk.java:1086)
12:31:39 [SCHWERWIEGEND] at zz.a(Chunk.java:1050)
12:31:39 [SCHWERWIEGEND] at aam.loadEntities(AnvilChunkLoader.java:512)
12:31:39 [SCHWERWIEGEND] at org.bukkit.craftbukkit.v1_4_R1.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:49)
12:31:39 [SCHWERWIEGEND] at org.bukkit.craftbukkit.v1_4_R1.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:15)
12:31:39 [SCHWERWIEGEND] at org.bukkit.craftbukkit.v1_4_R1.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:179)
12:31:39 [SCHWERWIEGEND] at org.bukkit.craftbukkit.v1_4_R1.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:287)
12:31:39 [SCHWERWIEGEND] at org.bukkit.craftbukkit.v1_4_R1.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:26)
12:31:39 [SCHWERWIEGEND] at net.minecraft.server.MinecraftServer.r(MinecraftServer.java:907)
12:31:39 [SCHWERWIEGEND] at ho.r(DedicatedServer.java:309)
12:31:39 [SCHWERWIEGEND] at net.minecraft.server.MinecraftServer.q(MinecraftServer.java:857)
12:31:39 [SCHWERWIEGEND] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:744)
12:31:39 [SCHWERWIEGEND] at fy.run(ThreadMinecraftServer.java:16)

Is that what you were looking for? We are using L15 of MCPC+ for 1.4.7


EDIT: I just checked, this commit seems to be only for the 1.5.x supporting version of MCPC+, not for the 1.4.7 supporting one.

 

[UnionCraft]

Asdrubael
Is that error from a server running the L15 of MCPC+ 1.4.7 Legacy?
This was suppose to be fixed on the 1.4.7 version aswell as 1.5.1

Looking at it more, this is not the same error. From what I remember the console would be spammed with that error but would not crash, unlike the:

java.lang.NullPointerException
at codechicken.xycraftcopy.core.world.WorldExtension.loadChunkData(WorldExtension.java:57)
at codechicken.xycraftcopy.core.world.WorldExtensionManager$WorldExtensionEventHandler.onChunkDataLoad(WorldExtensionManager.java:38)
at net.minecraftforge.event.ASMEventHandler_182_WorldExtensionEventHandler_onChunkDataLoad_Load.invoke(.dynamic)
at net.minecraftforge.event.ASMEventHandler.invoke(ASMEventHandler.java:35)
at net.minecraftforge.event.EventBus.post(EventBus.java:103)
at aam.checkedReadChunkFromNBT(AnvilChunkLoader.java:163)
at aam.loadChunk__Async_CB(AnvilChunkLoader.java:132)

Error which would crash the server.

 

[Asdrubael]

Hello UinionCraft,

shame on me, you were right! I only had this message once, but that was before I upgraded to L15.

 

[OniBait]

Nallar's change should fix the errors that Xycraft was throwing:

java.lang.NullPointerException
at codechicken.xycraftcopy.core.world.WorldExtension.loadChunkData(WorldExtension.java:57)

The fix was moving an async call into the same sync code so that the order is the same as Xycraft was expecting. (ChunkData.Load would sometimes fire before Chunk.Load)